Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt to include docx #1798

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nickvanlandschoot
Copy link

Description

  • Summary of changes: This is a very small one line change to include docx.
  • Related issues: In v.2.7.7 there was an issue preventing custom agents from loading in the playground which relates to Playground UI not working in v2.7.7 #1738
    Since then the playground functionality has been working but users must install python-docx. This change installs docx by default.
  • Motivation and context: Change improves dx by including a core dependency by default rather than forcing the users to manually add in the dependency themselves.
  • Environment or dependencies: No config changes but must reinstall reqs or manually install python-docx still.
  • Impact on AI/ML components: No changes here

Fixes #1797

Type of change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update
  • Infrastructure change

Checklist

  • My code follows Phidata's style guidelines and best practices
  • I have performed a self-review of my code
  • I have added docstrings and comments for complex logic (N/A)
  • My changes generate no new warnings or errors
  • I have added cookbook examples for my new addition (if needed) (N/A)
  • I have updated requirements.txt/pyproject.toml (if needed) (N/A)
  • I have verified my changes in a clean environment (N/A)

Additional Notes

1.1.2 is the latest stable version for python-docx and doesn't appear to have any major bugs nor does it appear to cause any conflicts with any other dependencies of phidata thus the selected version.

This is a very small one line change to include docx.

In v.2.7.7 there was an issue preventing custom agents from loading in the playground.
phidatahq#1738

Since then the playground functionality has been working but users must install python-docx

This change installs docx by default.

1.1.2 is the latest stable version and doesn't appear to have any major bugs nor does it appear to cause any conflicts with any other dependencies of phidata thus the version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include python-docx as a Default Dependency
1 participant